Add inline images in mandrill adapter #608
Conversation
|
|
||
| mandrill_message | ||
| |> Map.put(:attachments, format_attachments(files)) | ||
| |> Map.put(:images, format_attachments(images)) |
There was a problem hiding this comment.
Do you know why we're calling this images? Will inline attachments always be images or is that how mandrill categorizes inline attachments?
There was a problem hiding this comment.
Yes, of course! https://mailchimp.com/developer/transactional/api/messages/send-new-message/
Inside message attribute at the end.
Is similar to attachments with the difference of send the cid instead of the filename.
There was a problem hiding this comment.
Thanks for sending that link. That's very helpful! This is the section I'm looking at:
Based on what I'm seeing, the changes in this PR seem good.
My only lingering question is: do you know if it's possible to add non-image files as inline attachments?
- If that's the case, then someone could add a non-image attachment with
content-idbut we would incorrectly put it in the:imagesfield. - If Mandrill only allows for images as inline attachments, then I think this PR is good to go.
There was a problem hiding this comment.
I added a new commit to check the content_type too before add it as inline image.
|
Thanks a lot for you @germsvel!! 🍻 |
This PR adds support to send to mandrill inline images.